Enforce case-insensitively unique feature view names

[codyjlin]

Signed-off-by: Cody Lin [email protected]

What this PR does / why we need it:
CockroachDB's table names and the materialization jobs using dataflow need feature view names to be lowercase. (CRDB is an online store we're trying to use.) We can transform the names downstream / on our end, but we would like the collision check to happen at feast apply time.

Which issue(s) this PR fixes:

It's such a small change that no issue created.

Does this PR introduce a user-facing change?:

FeatureView names must now be *case-insensitively* unique

[feast-ci-bot]

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codyjlin]

/ok-to-test

[feast-ci-bot]

@codyjlin: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[achals]

I think this is fine, but is going to be a breaking change in case anyway was relying on this behavior.

Any tests to update for this?

[codyjlin]

Any tests to update for this?

@achals Ah, didn't realize there were tests for this validation check. Updating the failed tests and modifying one to test the case-insensitive case.

[codecov-commenter]

Codecov Report

Merging #1835 (2e8ca40) into master (09e0955) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   84.32%   84.69%   +0.37%     
==========================================
  Files          93       90       -3     
  Lines        6869     7003     +134     
==========================================
+ Hits         5792     5931     +139     
+ Misses       1077     1072       -5     

Flag	Coverage Δ
integrationtests	84.62% <100.00%> (+0.37%)	⬆️
unittests	63.58% <100.00%> (+0.51%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ion/test_cli_apply_duplicated_featureview_names.py	100.00% <ø> (ø)
sdk/python/feast/feature_store.py	92.98% <100.00%> (+0.02%)	⬆️
...sts/integration/registration/test_feature_store.py	99.31% <100.00%> (ø)
sdk/python/feast/infra/online_stores/redis.py	92.85% <0.00%> (-1.79%)	⬇️
sdk/python/feast/infra/online_stores/sqlite.py	97.75% <0.00%> (-1.05%)	⬇️
...ts/integration/feature_repos/repo_configuration.py	100.00% <0.00%> (ø)
...s/integration/registration/test_universal_types.py	100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py	100.00% <0.00%> (ø)
...fline_store/test_universal_historical_retrieval.py	100.00% <0.00%> (ø)
...hon/tests/integration/registration/test_cli_gcp.py
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e0955...2e8ca40. Read the comment docs.

[codyjlin]

/retest

[codyjlin]

/retest

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, codyjlin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codyjlin]

/kind bug