Replace individual cli tests with parametrized tests #1830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
==========================================
- Coverage 84.31% 84.04% -0.28%
==========================================
Files 93 90 -3
Lines 6865 6761 -104
==========================================
- Hits 5788 5682 -106
- Misses 1077 1079 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.parametrize("test_repo_config", FULL_REPO_CONFIGS) | ||
| def test_universal_cli(test_repo_config) -> None: |
There was a problem hiding this comment.
test_cli_local seems to have a lot of tests that check other commands. Do we want to add them here too?
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
achals
force-pushed
the
achal/cli-tests
branch
from
e3879d7
to
f1e71d4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
More coverage with fewer test files.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: