Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latency telemetry #1822

Closed

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Sep 1, 2021

What this PR does / why we need it: This PR adds latency telemetry to provider methods, online store methods, and offline store methods.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Copy link
Collaborator Author

/retest

@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

@felixwang9817
Copy link
Collaborator Author

/retest

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #1822 (43b6de9) into master (2d52ce7) will decrease coverage by 0.01%.
The diff coverage is 79.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
- Coverage   84.84%   84.83%   -0.02%     
==========================================
  Files          91       91              
  Lines        6924     7014      +90     
==========================================
+ Hits         5875     5950      +75     
- Misses       1049     1064      +15     
Flag Coverage Δ
integrationtests 84.75% <79.38%> (-0.02%) ⬇️
unittests 63.67% <79.38%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/provider.py 82.83% <23.07%> (-6.43%) ⬇️
sdk/python/feast/usage.py 63.20% <62.96%> (+2.24%) ⬆️
sdk/python/feast/infra/aws.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/gcp.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/local.py 93.10% <100.00%> (+0.94%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 82.55% <100.00%> (+0.60%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 97.52% <100.00%> (+0.08%) ⬆️
sdk/python/feast/infra/offline_stores/redshift.py 91.52% <100.00%> (+0.53%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 93.70% <100.00%> (+0.25%) ⬆️
sdk/python/feast/infra/online_stores/dynamodb.py 91.66% <100.00%> (+0.52%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d52ce7...43b6de9. Read the comment docs.

@felixwang9817
Copy link
Collaborator Author

Closed due to #1983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants