Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the datastore online_read method to be slightly more efficient #1819

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

achals
Copy link
Member

@achals achals commented Aug 31, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@achals achals force-pushed the achal/batch-datastore branch from 0776d8a to a960eee Compare August 31, 2021 18:22
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #1819 (a960eee) into master (e895bc4) will decrease coverage by 20.93%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1819       +/-   ##
===========================================
- Coverage   84.84%   63.91%   -20.94%     
===========================================
  Files          92       89        -3     
  Lines        6844     6718      -126     
===========================================
- Hits         5807     4294     -1513     
- Misses       1037     2424     +1387     
Flag Coverage Δ
integrationtests ?
unittests 63.91% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/datastore.py 30.32% <0.00%> (-63.17%) ⬇️
.../integration/online_store/test_universal_online.py 16.32% <0.00%> (-83.68%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 20.25% <0.00%> (-79.75%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 30.37% <0.00%> (-60.76%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e895bc4...a960eee. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 95d1d5b into feast-dev:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants