Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomly generating new BQ dataset for offline_online_store_consistency test #1818

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 31, 2021

What this PR does / why we need it:
Generating unique BQ datasets for the offline_online_store_consistency to avoid ACL issues with updating existing datasets

Which issue(s) this PR fixes:

Fixes #1760

Does this PR introduce a user-facing change?:

NONE

…test so test not broken for people who don't have admin privileges on BQ project

Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #1818 (033a9b7) into master (998e169) will decrease coverage by 20.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1818       +/-   ##
===========================================
- Coverage   84.85%   63.90%   -20.95%     
===========================================
  Files          92       89        -3     
  Lines        6828     6719      -109     
===========================================
- Hits         5794     4294     -1500     
- Misses       1034     2425     +1391     
Flag Coverage Δ
integrationtests ?
unittests 63.90% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...alization/test_offline_online_store_consistency.py 56.57% <0.00%> (-43.43%) ⬇️
.../integration/online_store/test_universal_online.py 16.32% <0.00%> (-83.68%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 20.25% <0.00%> (-79.75%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 30.08% <0.00%> (-63.03%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998e169...033a9b7. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adchia
Copy link
Collaborator Author

adchia commented Aug 31, 2021

/retest

@adchia adchia merged commit d40636d into feast-dev:master Aug 31, 2021
@adchia adchia deleted the bqfix branch September 1, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BigQuery related integration tests to make unique BQ datasets and tables
4 participants