-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomly generating new BQ dataset for offline_online_store_consistency test #1818
Conversation
…test so test not broken for people who don't have admin privileges on BQ project Signed-off-by: Danny Chiao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1818 +/- ##
===========================================
- Coverage 84.85% 63.90% -20.95%
===========================================
Files 92 89 -3
Lines 6828 6719 -109
===========================================
- Hits 5794 4294 -1500
- Misses 1034 2425 +1391
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
Generating unique BQ datasets for the offline_online_store_consistency to avoid ACL issues with updating existing datasets
Which issue(s) this PR fixes:
Fixes #1760
Does this PR introduce a user-facing change?: