Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure Terraform installation. #1793

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Fix Azure Terraform installation. #1793

merged 1 commit into from
Aug 24, 2021

Conversation

mmurdoch
Copy link
Contributor

Helm chart for Feast in the Terraform installation changed to
point to the location referenced in the Azure Helm installation
documentation (https://docs.feast.dev/feast-on-kubernetes-1/getting-started/install-feast/kubernetes-azure-aks-with-helm)

Which issue(s) this PR fixes:
Fixes #1792

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmurdoch
To complete the pull request process, please assign woop after the PR has been reviewed.
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @mmurdoch. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #1793 (82c7d99) into master (2e5f6e8) will decrease coverage by 21.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1793       +/-   ##
===========================================
- Coverage   85.35%   63.54%   -21.82%     
===========================================
  Files          88       85        -3     
  Lines        6584     6498       -86     
===========================================
- Hits         5620     4129     -1491     
- Misses        964     2369     +1405     
Flag Coverage Δ
integrationtests ?
unittests 63.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 16.32% <0.00%> (-83.68%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 20.25% <0.00%> (-79.75%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 31.03% <0.00%> (-62.07%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 30.37% <0.00%> (-60.76%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5f6e8...82c7d99. Read the comment docs.

Helm chart for Feast in the Terraform installation changed to
point to the location referenced in the Azure Helm installation
documentation (https://docs.feast.dev/feast-on-kubernetes-1/getting-started/install-feast/kubernetes-azure-aks-with-helm)

Fixes issue 1792

Signed-off-by: Matthew Murdoch <[email protected]>
@woop woop merged commit a81c27b into feast-dev:master Aug 24, 2021
@woop
Copy link
Member

woop commented Aug 24, 2021

Thanks @mmurdoch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure AKS Terraform installation fails with feast charts not found
4 participants