Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3 support (with custom endpoints) #1789

Merged
merged 8 commits into from
Aug 22, 2021
Merged

Conversation

woop
Copy link
Member

@woop woop commented Aug 18, 2021

What this PR does / why we need it:

Refactored #1549 to work with the new test suite. Also added support for testing S3 using Minio.

Added @qooba as co-author.

Which issue(s) this PR fixes:

Fixes #1548

Does this PR introduce a user-facing change?:

Added support for S3 as well as S3 with custom endpoints

qooba and others added 3 commits August 18, 2021 14:12
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #1789 (5986998) into master (da436b5) will decrease coverage by 21.44%.
The diff coverage is 55.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1789       +/-   ##
===========================================
- Coverage   85.37%   63.92%   -21.45%     
===========================================
  Files          88       89        +1     
  Lines        6583     6700      +117     
===========================================
- Hits         5620     4283     -1337     
- Misses        963     2417     +1454     
Flag Coverage Δ
integrationtests ?
unittests 63.92% <55.81%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tegration/feature_repos/test_repo_configuration.py 68.02% <0.00%> (-31.98%) ⬇️
...tegration/feature_repos/universal/feature_views.py 63.63% <ø> (-36.37%) ⬇️
...tegration/offline_store/test_s3_custom_endpoint.py 25.00% <25.00%> (ø)
...k/python/feast/infra/offline_stores/file_source.py 85.05% <83.33%> (-0.86%) ⬇️
sdk/python/feast/infra/offline_stores/file.py 97.14% <100.00%> (+0.05%) ⬆️
...ion/feature_repos/universal/data_source_creator.py 77.77% <100.00%> (ø)
.../integration/online_store/test_universal_online.py 16.32% <0.00%> (-83.68%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 20.25% <0.00%> (-79.75%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da436b5...5986998. Read the comment docs.

woop added 3 commits August 18, 2021 14:20
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
@woop woop mentioned this pull request Aug 18, 2021
@woop woop added the kind/feature New feature or request label Aug 18, 2021
f: Any
minio: DockerContainer
bucket = "feast-test"
access_key = "AKIAIOSFODNN7EXAMPLE"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really get around hardcoding access_key and secret in two places right now. The test suite doesn't allow us to inject configuration. cc @achals it would be nice if we could propagate a config (context-like) object.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed yeah I'll make a task for that

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

return zip(schema.names, map(str, schema.types))

@staticmethod
def prepare_path(path: str, s3_endpoint_override: str):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, type annotations for the output of this method?

f: Any
minio: DockerContainer
bucket = "feast-test"
access_key = "AKIAIOSFODNN7EXAMPLE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed yeah I'll make a task for that

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Willem Pienaar <[email protected]>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 22, 2021
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

Signed-off-by: Willem Pienaar <[email protected]>
@woop woop merged commit d16cc6b into feast-dev:master Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add S3 support to FileSource
5 participants