-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add online feature retrieval integration test using the universal repo #1783
Add online feature retrieval integration test using the universal repo #1783
Conversation
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1783 +/- ##
==========================================
+ Coverage 85.20% 85.53% +0.32%
==========================================
Files 87 88 +1
Lines 6501 6656 +155
==========================================
+ Hits 5539 5693 +154
- Misses 962 963 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
Show resolved
Hide resolved
sdk/python/tests/integration/feature_repos/universal/feature_views.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
sdk/python/tests/integration/feature_repos/universal/feature_views.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Achal Shah <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: