Add offline retrival integration tests using the universal repo

[achals]

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

We wanna start parameterizing over all the possible combinations when reading feature values from the offline feature store. This PR introduces the decorator needed to set up the underlying tables as needed, updates the historical integration test to operate on an Environment object.

$ FEAST_TELEMETRY=False pytest --cov=./ --cov-report=xml --color=yes -s --integration sdk/python/tests/integration/offline_store/test_universal_historical_retrieval.py -n 8
======================================================================================= test session starts =======================================================================================
platform darwin -- Python 3.7.11, pytest-6.0.0, py-1.10.0, pluggy-0.13.1
rootdir: /Users/achal/tecton/feast/sdk/python
plugins: cov-2.12.1, xdist-2.3.0, ordering-0.6, mock-1.10.4, timeout-1.4.2, forked-1.3.0, lazy-fixture-0.6.3
gw0 [20] / gw1 [20] / gw2 [20] / gw3 [20] / gw4 [20] / gw5 [20] / gw6 [20] / gw7 [20]
....................

---------- coverage: platform darwin, python 3.7.11-final-0 ----------
Coverage XML written to file coverage.xml

================================================================================= 20 passed in 162.39s (0:02:42) ==================================================================================

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Merging #1769 (ef9db2e) into master (7977a53) will decrease coverage by 20.86%.
The diff coverage is 46.66%.

@@             Coverage Diff             @@
##           master    #1769       +/-   ##
===========================================
- Coverage   84.65%   63.78%   -20.87%     
===========================================
  Files          85       84        -1     
  Lines        6268     6415      +147     
===========================================
- Hits         5306     4092     -1214     
- Misses        962     2323     +1361     

Flag	Coverage Δ
integrationtests	?
unittests	63.78% <46.66%> (-0.74%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...gration/offline_store/test_historical_retrieval.py	45.59% <0.00%> (-53.37%)	⬇️
...fline_store/test_universal_historical_retrieval.py	20.25% <20.25%> (ø)
...alization/test_offline_online_store_consistency.py	56.57% <33.33%> (-43.43%)	⬇️
...tegration/feature_repos/universal/feature_views.py	63.63% <42.85%> (-36.37%)	⬇️
...ts/integration/feature_repos/universal/entities.py	60.00% <50.00%> (-40.00%)	⬇️
...python/tests/integration/e2e/test_universal_e2e.py	28.88% <55.55%> (-56.48%)	⬇️
...tegration/feature_repos/test_repo_configuration.py	67.17% <66.00%> (-32.83%)	⬇️
...ion/feature_repos/universal/data_source_creator.py	77.77% <83.33%> (-0.80%)	⬇️
.../integration/online_store/test_online_retrieval.py	17.39% <0.00%> (-82.61%)	⬇️
sdk/python/tests/utils/online_read_write_test.py	18.18% <0.00%> (-81.82%)	⬇️
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7977a53...ef9db2e. Read the comment docs.

[adchia]

remove these?

[adchia]

or if you want to fix it, consider moving into separate test as I suggest below

[achals]

I'm going to remove them because the behaviour isn't actually consistent across offline stores. File sources don't support sql queries at all.

[adchia]

thoughts on splitting sql vs df into two separate tests with the same initial setup? would make it so one can distinguish from test failures whether their bug is in common logic or logic specific to sql vs df

[achals]

I think a single test is better - sql and df params are testing the same API roughly, and tests will run faster if there's fewer separate tests.

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adchia]

/lgtm