Adding small note for project naming convention

[codyjlin]

Signed-off-by: Cody Lin [email protected]

What this PR does / why we need it:
Unfortunately I had accidentally specified a project name with a dash. The error that popped up was from sqlite (following a store.apply call when trying to create tables in the online store.):

sqlite3.OperationalError: near “-”: syntax error

which actually took me some extra debugging to figure out what my issue was.

Which issue(s) this PR fixes:
N/A. Too small for a PR, but it could be related to overall validation or more docs specifying naming limitations.

Does this PR introduce a user-facing change?:

NONE

[feast-ci-bot]

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[achals]

Thanks for the PR @codyjlin. Do you think we should be adding some validation in code to catch this and raise a better exception?

[mavysavydav]

LGTM

[codyjlin]

Thanks for the PR @codyjlin. Do you think we should be adding some validation in code to catch this and raise a better exception?

@achals I think so since the error message I did get was pretty unhelpful, but I'm not sure how frequently users would run into this error - might not be something to prioritize right now.

[tedhtchang]

@codyjlin You may call the name validation function here to validate the project name. Or you can create an issue and assign to me.

[codyjlin]

Thanks @tedhtchang!! Just created #1755.

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, codyjlin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Merging #1752 (110f89d) into master (8b3a97a) will decrease coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
- Coverage   84.46%   82.90%   -1.57%     
==========================================
  Files          82       73       -9     
  Lines        7093     6439     -654     
==========================================
- Hits         5991     5338     -653     
+ Misses       1102     1101       -1     

Flag	Coverage Δ
integrationtests	83.66% <ø> (-0.73%)	⬇️
unittests	64.14% <ø> (-5.36%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_table.py	44.05% <0.00%> (-48.26%)	⬇️
sdk/python/feast/loaders/yaml.py	18.18% <0.00%> (-45.46%)	⬇️
sdk/python/feast/feature.py	75.00% <0.00%> (-16.67%)	⬇️
sdk/python/feast/entity.py	73.98% <0.00%> (-14.31%)	⬇️
sdk/python/feast/data_format.py	65.30% <0.00%> (-14.29%)	⬇️
sdk/python/feast/data_source.py	57.00% <0.00%> (-12.71%)	⬇️
sdk/python/feast/registry.py	74.10% <0.00%> (-6.72%)	⬇️
sdk/python/feast/cli.py	43.67% <0.00%> (-2.85%)	⬇️
...k/python/feast/infra/offline_stores/file_source.py	85.91% <0.00%> (-2.82%)	⬇️
sdk/python/feast/online_response.py	94.87% <0.00%> (-2.57%)	⬇️
... and 72 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b3a97a...110f89d. Read the comment docs.