Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how pandas deals with missing values #1748

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jul 30, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #1748 (dc1cf1b) into master (de8a1b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1748   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files          73       73           
  Lines        6003     6003           
=======================================
  Hits         5040     5040           
  Misses        963      963           
Flag Coverage Δ
integrationtests 83.87% <ø> (ø)
unittests 64.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/file.py 97.08% <ø> (ø)
sdk/python/feast/infra/utils/aws_utils.py 91.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8a1b6...dc1cf1b. Read the comment docs.

@achals
Copy link
Member Author

achals commented Jul 30, 2021

/retest

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member Author

achals commented Jul 30, 2021

/retest

@feast-ci-bot feast-ci-bot merged commit 1841bb3 into feast-dev:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants