-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore feature refs #1746
Restore feature refs #1746
Conversation
Signed-off-by: Felix Wang <[email protected]>
…essary Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
===========================================
- Coverage 79.10% 61.95% -17.15%
===========================================
Files 81 79 -2
Lines 6938 6855 -83
===========================================
- Hits 5488 4247 -1241
- Misses 1450 2608 +1158
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/kind housekeeping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@tedhtchang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: #1691 allows for specifying FeatureServices in FeatureStore methods, but introduced a breaking change by renaming
feature_refs
tofeatures
. This PR ensures the change is not breaking, and inserts the appropriate DeprecationWarning.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: