Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency on pyyaml #1742

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

achals
Copy link
Member

@achals achals commented Jul 28, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1738

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Achal Shah <[email protected]>
@achals achals requested review from tsotnet, woop and a team as code owners July 28, 2021 23:18
@achals achals requested review from felixwang9817 and removed request for a team, tsotnet and woop July 28, 2021 23:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1742 (f803c85) into master (95a245a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files          81       81           
  Lines        6938     6938           
=======================================
  Hits         5488     5488           
  Misses       1450     1450           
Flag Coverage Δ
integrationtests 79.02% <ø> (ø)
unittests 61.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a245a...f803c85. Read the comment docs.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 2dfdace into feast-dev:master Jul 28, 2021
@achals achals deleted the achal/bump-pyyaml branch July 28, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency PyYAML 5.3.* has vulnerability issues
4 participants