-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Template improvements (input prompt for configs, default to Redshift) #1731
AWS Template improvements (input prompt for configs, default to Redshift) #1731
Conversation
…ift) Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
- Coverage 79.08% 78.97% -0.11%
==========================================
Files 80 80
Lines 6855 6878 +23
==========================================
+ Hits 5421 5432 +11
- Misses 1434 1446 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AWS Template improvements (input prompt for configs, default to Redshift)
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: Currently AWS template uses dynamodb online store and file offline store. We're now changing the offline store to Redshift. However, Redshift needs to be configured by the user to make things work (e.g. cluster_id, database name, etc.). We don't have a mechanism for that. This PR adds python-inquirer library for user prompt during aws template bootstrap, which is used for configuring the feature_store.yaml. Here's the new flow in action:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: