Implement Redshift historical retrieval #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsotne Tabidze <[email protected]>
added 2 commits
July 19, 2021 11:40
Signed-off-by: Tsotne Tabidze <[email protected]>
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
woop
reviewed
Jul 19, 2021
|
Directionally this PR looks good to me. |
added 3 commits
July 20, 2021 13:34
Fixed get_historical_features where entity_df is a SQL query, while keeping the utility functions common between Redshift and BigQuery. `infer_event_timestamp_from_entity_df` and `assert_expected_columns_in_entity_df` are now based on the entity schema rather than the dataframe. I also completely removed the min/max timestamp inference, since those could not be merged (needed to query BigQuery and Redshift). Instead, I moved the logic inside the SQL templates, reducing the code complexity. Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
+ Coverage 78.69% 79.01% +0.31%
==========================================
Files 80 80
Lines 6765 6849 +84
==========================================
+ Hits 5324 5412 +88
+ Misses 1441 1437 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
reviewed
Jul 21, 2021
Co-authored-by: Willem Pienaar <[email protected]> Signed-off-by: Tsotne Tabidze <[email protected]>
tsotnet
force-pushed
the
redshift_historical_retrieval
branch
from
44154ee to
1da26bf
Compare
Signed-off-by: Tsotne Tabidze <[email protected]>
added 3 commits
July 22, 2021 13:07
Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
woop
reviewed
Jul 23, 2021
woop
reviewed
Jul 23, 2021
sdk/python/tests/integration/offline_store/test_historical_retrieval.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Tsotne Tabidze <[email protected]>
woop
approved these changes
Jul 23, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: This PR implements
RedfshiftOfflineStore:get_historical_features. Also refactored couple of methods from bigquery.py and moved them in common_utils.py so that both RedshiftOfflineStore and BigQueryOfflineStore can use them.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: