-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python to Feast list[int]
mapping
#1700
Conversation
Corrects a case where if elements in list were not `numpy` types type mapping would fail.
@judahrand: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: judahrand The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes an issue mentioned in #1640 but not the whole issue as this still does not deal with empty lists. |
/assign @jklega |
@judahrand: GitHub didn't allow me to assign the following users: jklega. Note that only feast-dev members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is great @judahrand! I'd love to merge this PR, but unfortunately it will probably be blocked by the lack of a test that ensures all our types are working. That isn't really your fault, it's just a technical debt in the project. We still need to write a test that runs through all the types. |
Codecov Report
@@ Coverage Diff @@
## master #1700 +/- ##
===========================================
- Coverage 82.75% 69.73% -13.02%
===========================================
Files 76 74 -2
Lines 6754 6664 -90
===========================================
- Hits 5589 4647 -942
- Misses 1165 2017 +852
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Wanted to follow up here. I believe this was already fixed in the main repo (presumably after this PR), so closing this. Thanks again though for adding the fix! We added some basic tests for types, but still a work in progress. |
Corrects a case where if elements in list were not
numpy
typestype mapping would fail.
What this PR does / why we need it:
Fixes case where type mapping failed (in my case from Parquet FileSource)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: