-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FeatureService proto definition #1676
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1676 +/- ##
==========================================
- Coverage 82.70% 82.56% -0.14%
==========================================
Files 75 76 +1
Lines 6665 6698 +33
==========================================
+ Hits 5512 5530 +18
- Misses 1153 1168 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we fix entities
then I think we're good.
Oops, we're still planning to rename FeatureReference. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
b7d4389
to
ab4b248
Compare
Btw @achals, if your PR has "Fixes #[0-9]+", then it will actually close the corresponding issue when the PR lands. |
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1572
Does this PR introduce a user-facing change?: