Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeatureService proto definition #1676

Merged
merged 6 commits into from
Jul 6, 2021

Conversation

achals
Copy link
Member

@achals achals commented Jun 30, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1572

Does this PR introduce a user-facing change?:

Introduce FeatureService to group Feature references

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #1676 (ab4b248) into master (cb1e7d7) will decrease coverage by 0.13%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
- Coverage   82.70%   82.56%   -0.14%     
==========================================
  Files          75       76       +1     
  Lines        6665     6698      +33     
==========================================
+ Hits         5512     5530      +18     
- Misses       1153     1168      +15     
Flag Coverage Δ
integrationtests 82.48% <54.54%> (-0.14%) ⬇️
unittests 69.65% <54.54%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 85.24% <25.00%> (-4.23%) ⬇️
sdk/python/feast/feature_view_projection.py 59.09% <59.09%> (ø)
...dk/python/tensorflow_metadata/proto/v0/path_pb2.py 100.00% <100.00%> (ø)
.../python/tensorflow_metadata/proto/v0/schema_pb2.py 100.00% <100.00%> (ø)
...hon/tensorflow_metadata/proto/v0/statistics_pb2.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1e7d7...ab4b248. Read the comment docs.

Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we fix entities then I think we're good.

@woop
Copy link
Member

woop commented Jul 5, 2021

/lgtm

Oops, we're still planning to rename FeatureReference.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop removed the lgtm label Jul 5, 2021
achals added 6 commits July 5, 2021 20:52
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@achals achals added kind/feature New feature or request lgtm and removed needs-kind labels Jul 6, 2021
@feast-ci-bot feast-ci-bot merged commit 4d0ea72 into feast-dev:master Jul 6, 2021
@achals achals deleted the achal/feature-service branch July 6, 2021 04:03
@woop
Copy link
Member

woop commented Jul 6, 2021

Btw @achals, if your PR has "Fixes #[0-9]+", then it will actually close the corresponding issue when the PR lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Feature Services
4 participants