-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table_refs in BigQuerySource definitions #1644
Fix table_refs in BigQuerySource definitions #1644
Conversation
Signed-off-by: Tsotne Tabidze <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 71 71
Lines 6113 6113
=======================================
Hits 5098 5098
Misses 1015 1015
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Tsotne Tabidze <[email protected]>
Signed-off-by: Tsotne Tabidze <[email protected]>
/lgtm |
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: I added a public dataset under feast-oss with 3 empty tables: drivers, customers, and customer_driver:
Subsequently, I replaced all mentions of
rh_prod.ride_hailing_co
byfeast-oss.public
. This should unblock #1627.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: