Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove granularity #162

Merged
merged 20 commits into from
Mar 22, 2019
Merged

Conversation

pradithya
Copy link
Collaborator

@pradithya pradithya commented Mar 22, 2019

Removal of granularity from all component of Feast.
Feature ID now has format of "[entity_name].[feature_name]".

The implementation has been tested in development cluster.

Fix #17

@zhilingc
Copy link
Collaborator

Also fixed a few small bugs introduced by PR #154.

@zhilingc
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhilingc
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit cf45d0f into feast-dev:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants