-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow telemetry configuration to fail gracefully #1612
Allow telemetry configuration to fail gracefully #1612
Conversation
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
- Coverage 83.61% 83.58% -0.04%
==========================================
Files 65 65
Lines 5761 5768 +7
==========================================
+ Hits 4817 4821 +4
- Misses 944 947 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
…ream logging messages are formatted properly Signed-off-by: Achal Shah <[email protected]>
New changes are detected. LGTM label has been removed. |
@woop I added some configuration in Sample output:
|
Signed-off-by: Achal Shah <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah <[email protected]>
5036c03
to
5e7c65e
Compare
* Allow telemetry configuration to fail gracefully Signed-off-by: Achal Shah <[email protected]> * make format Signed-off-by: Achal Shah <[email protected]> * Configure logging in the __init__ module for feast so that all downstream logging messages are formatted properly Signed-off-by: Achal Shah <[email protected]> * Reorder config Signed-off-by: Achal Shah <[email protected]> * Fix integration tests Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
In some environments feast may be unable to writes files to the local filesystem because of it being readonly. Right now, this breaks the telemetry logging in a bad way. We should handle it gracefully.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: