Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow telemetry configuration to fail gracefully #1612

Merged

Conversation

achals
Copy link
Member

@achals achals commented Jun 1, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

In some environments feast may be unable to writes files to the local filesystem because of it being readonly. Right now, this breaks the telemetry logging in a bad way. We should handle it gracefully.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Allow telemetry configuration to fail gracefully

Signed-off-by: Achal Shah <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #1612 (5e7c65e) into master (87989b0) will decrease coverage by 0.03%.
The diff coverage is 31.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
- Coverage   83.61%   83.58%   -0.04%     
==========================================
  Files          65       65              
  Lines        5761     5768       +7     
==========================================
+ Hits         4817     4821       +4     
- Misses        944      947       +3     
Flag Coverage Δ
integrationtests 83.49% <31.81%> (-0.04%) ⬇️
unittests 77.36% <31.81%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/telemetry.py 61.53% <25.00%> (-1.09%) ⬇️
sdk/python/feast/__init__.py 88.23% <100.00%> (+1.56%) ⬆️
sdk/python/feast/repo_operations.py 32.00% <0.00%> (ø)
sdk/python/feast/infra/offline_stores/bigquery.py 91.03% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87989b0...5e7c65e. Read the comment docs.

@woop
Copy link
Member

woop commented Jun 1, 2021

/lgtm

…ream logging messages are formatted properly

Signed-off-by: Achal Shah <[email protected]>
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jun 1, 2021
@achals
Copy link
Member Author

achals commented Jun 1, 2021

@woop I added some configuration in feast/__init__ to configure logging, you wanna take one more look?

Sample output:

$ feast apply
06/01/2021 02:48:19 PM WARNING:Unable to configure telemetry

Signed-off-by: Achal Shah <[email protected]>
@woop
Copy link
Member

woop commented Jun 1, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Achal Shah <[email protected]>
@achals achals force-pushed the achal/fail-telemtery-gracefully branch from 5036c03 to 5e7c65e Compare June 2, 2021 00:38
@achals achals added the lgtm label Jun 2, 2021
@feast-ci-bot feast-ci-bot merged commit a2581c5 into feast-dev:master Jun 2, 2021
@achals achals deleted the achal/fail-telemtery-gracefully branch June 2, 2021 01:09
woop pushed a commit that referenced this pull request Jun 7, 2021
* Allow telemetry configuration to fail gracefully

Signed-off-by: Achal Shah <[email protected]>

* make format

Signed-off-by: Achal Shah <[email protected]>

* Configure logging in the __init__ module for feast so that all downstream logging messages are formatted properly

Signed-off-by: Achal Shah <[email protected]>

* Reorder config

Signed-off-by: Achal Shah <[email protected]>

* Fix integration tests

Signed-off-by: Achal Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants