Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append nanoseconds to dataset name in test_historical_retrival to prevent tests stomping over each other #1593

Merged
merged 6 commits into from
May 28, 2021
Merged

Append nanoseconds to dataset name in test_historical_retrival to prevent tests stomping over each other #1593

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
54822af
Append the python version to the dataset name in test_historical_retr…
achals May 28, 2021
19df93f
make format
achals May 28, 2021
bcbc459
use version_info to avoid mucking wiht strings
achals May 28, 2021
29df7b0
time_ns followed by randint
achals May 28, 2021
c4a3bd7
fix lint
achals May 28, 2021
afe0a38
Use 1000-9999 for fixed width
achals May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/python/tests/test_historical_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,9 @@ def test_historical_features_from_bigquery_sources(
) = generate_entities(start_date, infer_event_timestamp_col)

# bigquery_dataset = "test_hist_retrieval_static"
bigquery_dataset = f"test_hist_retrieval_{int(time.time())}"
woop marked this conversation as resolved.
Show resolved Hide resolved
bigquery_dataset = (
f"test_hist_retrieval_{int(time.time_ns())}_{random.randint(1000, 9999)}"
)

with BigQueryDataSet(bigquery_dataset), TemporaryDirectory() as temp_dir:
gcp_project = bigquery.Client().project
Expand Down