Make start and end timestamps tz aware in the CLI #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1590 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 65 65
Lines 5757 5758 +1
=======================================
+ Hits 4813 4814 +1
Misses 944 944
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
feast-ci-bot
added
release-note
and removed
do-not-merge/release-note-label-needed
labels
Signed-off-by: Achal Shah <[email protected]>
woop
approved these changes
May 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
woop
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Make start and end timestamps tz aware in the CLI Signed-off-by: Achal Shah <[email protected]> * make format Signed-off-by: Achal Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We log start and time information in the CLI, before converting the timestamps into tz-aware datetime objects. This results in a confusion when running
feast materialize-incrementalwhich only takes in an end_ts argument. The end_ts argument is tz-naive, but start_ts is tz-aware, which causes the time range that's logged to the console to be messed up.This PR changes the behaviour to add tz information at the boundary of the CLI so that log messages in the deeper classes as well as in the CLI are consistent.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: