Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage and remove MacOS integration tests #1562

Merged
merged 2 commits into from
May 15, 2021

Conversation

woop
Copy link
Member

@woop woop commented May 15, 2021

Signed-off-by: Willem Pienaar [email protected]

What this PR does / why we need it:

  • Adds code coverage reporting using https://codecov.io/
  • Removes integration tests for MacOs (unable to use Docker)

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Willem Pienaar <[email protected]>
@woop woop requested review from jklegar, tsotnet and a team as code owners May 15, 2021 00:16
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@77a7975). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1562   +/-   ##
=========================================
  Coverage          ?   77.47%           
=========================================
  Files             ?       64           
  Lines             ?     5496           
  Branches          ?        0           
=========================================
  Hits              ?     4258           
  Misses            ?     1238           
  Partials          ?        0           
Flag Coverage Δ
unittests 77.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a7975...0b6b429. Read the comment docs.

Signed-off-by: Willem Pienaar <[email protected]>
@woop woop changed the title Add code coverage Add test coverage and remove MacOS integration tests May 15, 2021
@woop woop merged commit 1436a02 into feast-dev:master May 15, 2021
woop added a commit that referenced this pull request May 19, 2021
* Add code coverage to unit tests

Signed-off-by: Willem Pienaar <[email protected]>

* Add coverage to PRs

Signed-off-by: Willem Pienaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants