Validate project and repo names for apply and init commands

[tedhtchang]

Signed-off-by: ted chang [email protected]

Validate project and project directory names contain only alphanumerical values and underscores.
Fixes #1545

Does this PR introduce a user-facing change?:

Validate project and repository names for apply and init commands

[feast-ci-bot]

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[woop]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@77a7975). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1558   +/-   ##
=========================================
  Coverage          ?   83.42%           
=========================================
  Files             ?       65           
  Lines             ?     5653           
  Branches          ?        0           
=========================================
  Hits              ?     4716           
  Misses            ?      937           
  Partials          ?        0           

Flag	Coverage Δ
integrationtests	83.42% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a7975...5d71932. Read the comment docs.

[dmatrix]

@tedhtchang @woop
Would it make sense to make it airtight by ensuring that no names start with "_<table_name>" as SQLite, I believe, disallows _sqlite_table_name or _table_name. WDYT?

(And a minor nit: Python style suggests that boolean functions
conventionally are isdigit() isalpha(), islower() etc. Should this be renamed as is_valid_name() ? ) Up to you guys. :-)

def not_valid_name(name: str) -> bool:    
"""Test project or repo names. True if names have characters other than alphanumeric values and underscores"""    return 
     return name.startswith("_") or re.compile(r"\W+").search(name) is not None

[woop]

@tedhtchang @woop
Would it make sense to make it airtight by ensuring that no names start with "_<table_name>" as SQLite, I believe, disallows _sqlite_table_name or _table_name. WDYT?

(And a minor nit: Python style suggests that boolean functions
conventionally are isdigit() isalpha(), islower() etc. Should this be renamed as is_valid_name() ? ) Up to you guys. :-)

def not_valid_name(name: str) -> bool:    
"""Test project or repo names. True if names have characters other than alphanumeric values and underscores"""    return 
     return name.startswith("_") or re.compile(r"\W+").search(name) is not None

Yea, both suggestions make sense to me

[tedhtchang]

@woop @dmatrix i will work on it.