Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-patch script #1554

Merged
merged 10 commits into from
Sep 7, 2021
Merged

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented May 12, 2021

Signed-off-by: Jacob Klegar [email protected]

What this PR does / why we need it: This script streamlines the release process to make a patch release much faster and simpler.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@jklegar
Copy link
Collaborator Author

jklegar commented May 12, 2021

/kind housekeeping

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #1554 (7f23579) into master (17d1874) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          90       90           
  Lines        6772     6772           
=======================================
  Hits         5719     5719           
  Misses       1053     1053           
Flag Coverage Δ
integrationtests 84.37% <ø> (ø)
unittests 63.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d1874...7f23579. Read the comment docs.

@jklegar jklegar force-pushed the jacob_release_script branch from 8d54b5c to 1950681 Compare May 27, 2021 21:01
@woop
Copy link
Member

woop commented May 28, 2021

@jklegar can you let me know when you are ready for review again?

@jklegar jklegar requested a review from achals as a code owner June 21, 2021 17:11
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good, some nits. I haven't actually run the script though

infra/scripts/release-patch.sh Outdated Show resolved Hide resolved
infra/scripts/release-patch.sh Outdated Show resolved Hide resolved
infra/scripts/release-patch.sh Outdated Show resolved Hide resolved
infra/scripts/release-patch.sh Outdated Show resolved Hide resolved
@woop
Copy link
Member

woop commented Jun 21, 2021

@tsotnet so the changelog still has to be manually filtered down? Is there a way to automate that?

@tsotnet
Copy link
Collaborator

tsotnet commented Aug 31, 2021

@tsotnet so the changelog still has to be manually filtered down? Is there a way to automate that?

What else do you recommend? The script has no idea which commits you want to cherry pick right? So you have to manually specify them

Signed-off-by: Tsotne Tabidze <[email protected]>
@woop
Copy link
Member

woop commented Sep 7, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit cc61405 into feast-dev:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants