-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instruction for install Feast on IKS and OpenShift using Kustomize #1534
Conversation
@tedhtchang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedhtchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: animeshsingh, pvaneck. Note that only feast-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/feast-on-kubernetes/getting-started/install-feast/ibm-cloud-iks-with-kustomize.md
Outdated
Show resolved
Hide resolved
@@ -1,23 +1,28 @@ | |||
# IBM Cloud Kubernetes Service \(IKS\) \(with Helm\) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this duplicate installation file? Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one will be replaced by the ibm-cloud-iks-with-kustomize.md.
|
||
## 2. IBM Cloud Block Storage Setup | ||
:warning: If you have RedHat OpenShift Cluster on IBM Cloud skip to this [section](#Security-Context-Constrain-Setup). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Constrain/Constraint/
docs/feast-on-kubernetes/getting-started/install-feast/ibm-cloud-iks-with-kustomize.md
Outdated
Show resolved
Hide resolved
**3. Preparation** | ||
|
||
Add the Feast Helm repository and download the latest charts: | ||
By default, in OpenShift, all pods or containers will use the [Restricted SCC](https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html) which prevents some pods to run as certain UID and causes installation to fail. In order to grant additional permissions, beyond those acquired with the restricted SCC, we need to use a different SCC. Since pods are created under the default or specified service accounts under the namespace, adding them to the `anyuid` SCC will resolve the failure. To do so, execute the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, in OpenShift, all pods or containers will use the [Restricted SCC](https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html) which prevents some pods to run as certain UID and causes installation to fail. In order to grant additional permissions, beyond those acquired with the restricted SCC, we need to use a different SCC. Since pods are created under the default or specified service accounts under the namespace, adding them to the `anyuid` SCC will resolve the failure. To do so, execute the following: | |
By default, in OpenShift, all pods or containers will use the [Restricted SCC](https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html) which limits the UIDs pods can run with, causing the Feast installation to fail. To overcome this, you can allow Feast pods to run with any UID by executing the following: |
## 4. Installation | ||
|
||
Install Feast using Helm. The pods may take a few minutes to initialize. | ||
You may optionally enable the Feast Jupyter which contains code examples to demonstrate Feast. Some examples require Kafka to stream real time features to the Feast online serving. To enable, edit the following properties in the `values.yaml` under the `manifests/contrib/feast` folder: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "component" after Jupyter.
159b4d8
to
0dbbc1e
Compare
@tedhtchang we're not reviewing anything here yet since it's a draft. Let us know if you want us to look at anything. |
Signed-off-by: ted chang <[email protected]>
0dbbc1e
to
b0c7cba
Compare
docs/feast-on-kubernetes/getting-started/install-feast/ibm-cloud-iks-with-kustomize.md
Outdated
Show resolved
Hide resolved
docs/feast-on-kubernetes/getting-started/install-feast/ibm-cloud-iks-with-kustomize.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Animesh Singh <[email protected]>
@woop This PR is ready to review. Please take a look. Thanks. |
/lgtm |
#1534) * Add instruction for install Feast on IKS using kustomize Signed-off-by: ted chang <[email protected]> * Apply suggestions from code review Co-authored-by: Animesh Singh <[email protected]> Co-authored-by: Animesh Singh <[email protected]>
Signed-off-by: ted chang [email protected]
Add instruction for install Feast on IKS and OpenShift on IBM Cloud using Kustomize.
Remove instruction for install Feast on IKS with helm
Update urls in README, CONTRIBUTOR, and SUMMARY md files.
Does this PR introduce a user-facing change?:
NONE