Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for install Feast on IKS and OpenShift using Kustomize #1534

Merged
merged 2 commits into from
May 18, 2021

Conversation

tedhtchang
Copy link
Contributor

Signed-off-by: ted chang [email protected]

Add instruction for install Feast on IKS and OpenShift on IBM Cloud using Kustomize.
Remove instruction for install Feast on IKS with helm
Update urls in README, CONTRIBUTOR, and SUMMARY md files.

Does this PR introduce a user-facing change?:
NONE

@tedhtchang tedhtchang requested review from jklegar, tsotnet, woop and a team as code owners May 5, 2021 07:59
@feast-ci-bot
Copy link
Collaborator

@tedhtchang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedhtchang
To complete the pull request process, please assign jklegar after the PR has been reviewed.
You can assign the PR to them by writing /assign @jklegar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tedhtchang tedhtchang changed the title Add instruction for install Feast on IKS using Kustomize (Draft) Add instruction for install Feast on IKS and OpenShift using Kustomize (Draft) May 5, 2021
@tedhtchang
Copy link
Contributor Author

/cc @pvaneck @animeshsingh

@feast-ci-bot
Copy link
Collaborator

@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: animeshsingh, pvaneck.

Note that only feast-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pvaneck @animeshsingh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/SUMMARY.md Outdated Show resolved Hide resolved
@@ -1,23 +1,28 @@
# IBM Cloud Kubernetes Service \(IKS\) \(with Helm\)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this duplicate installation file? Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one will be replaced by the ibm-cloud-iks-with-kustomize.md.


## 2. IBM Cloud Block Storage Setup
:warning: If you have RedHat OpenShift Cluster on IBM Cloud skip to this [section](#Security-Context-Constrain-Setup).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Constrain/Constraint/

**3. Preparation**

Add the Feast Helm repository and download the latest charts:
By default, in OpenShift, all pods or containers will use the [Restricted SCC](https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html) which prevents some pods to run as certain UID and causes installation to fail. In order to grant additional permissions, beyond those acquired with the restricted SCC, we need to use a different SCC. Since pods are created under the default or specified service accounts under the namespace, adding them to the `anyuid` SCC will resolve the failure. To do so, execute the following:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, in OpenShift, all pods or containers will use the [Restricted SCC](https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html) which prevents some pods to run as certain UID and causes installation to fail. In order to grant additional permissions, beyond those acquired with the restricted SCC, we need to use a different SCC. Since pods are created under the default or specified service accounts under the namespace, adding them to the `anyuid` SCC will resolve the failure. To do so, execute the following:
By default, in OpenShift, all pods or containers will use the [Restricted SCC](https://docs.openshift.com/container-platform/4.6/authentication/managing-security-context-constraints.html) which limits the UIDs pods can run with, causing the Feast installation to fail. To overcome this, you can allow Feast pods to run with any UID by executing the following:

## 4. Installation

Install Feast using Helm. The pods may take a few minutes to initialize.
You may optionally enable the Feast Jupyter which contains code examples to demonstrate Feast. Some examples require Kafka to stream real time features to the Feast online serving. To enable, edit the following properties in the `values.yaml` under the `manifests/contrib/feast` folder:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "component" after Jupyter.

@tedhtchang tedhtchang force-pushed the ibm-ids-with-kustomize branch from 159b4d8 to 0dbbc1e Compare May 8, 2021 05:46
@woop
Copy link
Member

woop commented May 13, 2021

@tedhtchang we're not reviewing anything here yet since it's a draft. Let us know if you want us to look at anything.

@tedhtchang tedhtchang force-pushed the ibm-ids-with-kustomize branch from 0dbbc1e to b0c7cba Compare May 14, 2021 17:40
@tedhtchang tedhtchang changed the title Add instruction for install Feast on IKS and OpenShift using Kustomize (Draft) Add instruction for install Feast on IKS and OpenShift using Kustomize May 14, 2021
@tedhtchang
Copy link
Contributor Author

@woop This PR is ready to review. Please take a look. Thanks.

@woop
Copy link
Member

woop commented May 18, 2021

/lgtm

@woop woop merged commit f050976 into feast-dev:master May 18, 2021
woop pushed a commit that referenced this pull request May 19, 2021
#1534)

* Add instruction for install Feast on IKS using kustomize

Signed-off-by: ted chang <[email protected]>

* Apply suggestions from code review

Co-authored-by: Animesh Singh <[email protected]>

Co-authored-by: Animesh Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants