-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Redis and Redis Cluster #1511
Conversation
Hi @qooba. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This is great work @qooba! Really surprised to see the implementation so quickly. We're still in the process of collecting feedback on the #1497, given that we may need to support a more scalable ingestion API for real time events. We may need a little bit of time before we can review and merge this code in, but we're super thankful for the contribution!! |
One thing that stands out is that we don't have any automated tests for Redis as part of this PR. We'll definitely need to extend the PR to also include an integration test. @qooba do you want to take a stab at that? One option is https://github.com/testcontainers/testcontainers-python, another is to just mark the tests as integration tests using |
Sure @woop I will extend PR with integration tests. |
/retest |
For some reason it's not allowing you to run tests until you've actually merged some code into Feast. I'll need to approve every time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @qooba! Yep we'll want integration tests to make sure these methods work in the same way as their GCP equivalents and don't rot in the future. For integration tests, adding a sdk/python/tests/test_cli_redis.py
that is the equivalent of sdk/python/tests/test_cli_gcp.py
should cover the main parts, plus adding redis into the GitHub actions workflows like Willem said above
@jklegar I have added |
The test
@jklegar can you help with this ? |
@qooba I've added the redis service to pr_integration_tests.yml in master, can you rebase this diff? Once you rebase it'll run the updated action here |
6b33786
to
b976599
Compare
Thanks @qooba and apologies for the delay here, it should be good to rebase now |
8f17664
to
55463af
Compare
Thanks @jklegar rebased and tests are passing now :) |
/kind feature |
771c4d2
to
bb18897
Compare
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: qooba <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
bb18897
to
e12ecff
Compare
/lgtm |
What this PR does / why we need it:
PR adds Redis and RedisCluster support as online store. As described in #1497 it is backward compatible with Feast 0.9 thus it can be used for migration to 0.10
Which issue(s) this PR fixes:
Fixes #1497
Does this PR introduce a user-facing change?: