Add support for third party providers #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsotnet
force-pushed
the
custom-providers
branch
from
b20c956 to
23dddd0
Compare
Signed-off-by: Tsotne Tabidze <[email protected]>
tsotnet
force-pushed
the
custom-providers
branch
from
23dddd0 to
1f101b2
Compare
woop
reviewed
Apr 23, 2021
woop
reviewed
Apr 23, 2021
…tin providers Signed-off-by: Tsotne Tabidze <[email protected]>
woop
approved these changes
Apr 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
woop
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Add support for third party providers Signed-off-by: Tsotne Tabidze <[email protected]> * Add unit tests & assume providers without dots in name refers to builtin providers Signed-off-by: Tsotne Tabidze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Currently there's no way to plug in custom providers in Feast CLI. With this PR, you can modify
providerfield in thefeature_store.yamlto a Python class path. For example, if you define your providerMyCustomProviderundermy_package.providers, you can specifyprovider: my_package.providers.MyCustomProviderand then normally runfeast applyor any other CLI command.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: