#12: prefetch specs and validate on job expansion #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portSpec and fetch their relevant storage spec, then validate
|
It also ensure that the job will fail early during expansion, if the feature specs, entity specs or storage specs aren't found. |
zhilingc
approved these changes
Dec 29, 2018
|
Woot! |
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
Jun 13, 2024
update the document change and fix teardown function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #12
This change stops the ingestion jobs talking to the core api during job execution. They just do it once during job expansion.
This means that all encountered features during the job MUST be specified in the import spec upfront.
This is particularly relevant for the streaming jobs which didn't require that before.
A pubsub importSpec, should list the feature ids required in the schema.
I haven't yet tested this on an real streaming job. So we should do that before merge.