Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update broken urls in contributing.md #1489

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Update broken urls in contributing.md #1489

merged 2 commits into from
Apr 27, 2021

Conversation

tedhtchang
Copy link
Contributor

@tedhtchang tedhtchang commented Apr 21, 2021 •
edited
Loading

Signed-off-by: ted chang [email protected]

What this PR does / why we need it:
These urls are broken

@feast-ci-bot
Copy link
Collaborator

@tedhtchang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedhtchang
To complete the pull request process, please assign jklegar after the PR has been reviewed.
You can assign the PR to them by writing /assign @jklegar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tedhtchang
Update broken urls
b603c16 
Signed-off-by: ted chang <[email protected]>
@tedhtchang tedhtchang changed the title Update urls that only exist in 0.9-branch document Update broken urls in contributing.md Apr 21, 2021
@woop
Copy link
Member

woop commented Apr 22, 2021

Thanks @tedhtchang, will update these shortly. It may be easier to do from our side since it spans branches.

@woop woop merged commit d6288a6 into feast-dev:master Apr 27, 2021
woop added a commit that referenced this pull request Apr 27, 2021
@tedhtchang @woop
Update broken urls in contributing.md (#1489)
e7d0112 
* Update broken urls

Signed-off-by: ted chang <[email protected]>

* Update CONTRIBUTING.md

Co-authored-by: Willem Pienaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklegar jklegar Awaiting requested review from jklegar

@tsotnet tsotnet Awaiting requested review from tsotnet

@woop woop Awaiting requested review from woop

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed kind/housekeeping needs-ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tedhtchang @feast-ci-bot @woop