Fix bug in allowing empty repositories to be applied to a GCS registry #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Willem Pienaar <[email protected]>
Signed-off-by: Willem Pienaar <[email protected]>
jklegar
approved these changes
Apr 21, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
tsotnet
reviewed
Apr 21, 2021
| @@ -71,7 +69,7 @@ def __init__(self, registry_path: str, repo_path: Path, cache_ttl: timedelta): | |||
|
|
|||
| def _initialize_registry(self): | |||
| """Explicitly forces the initialization of a registry""" | |||
| self._registry_store.update_registry_proto() | |||
| self._registry_store.update_registry_proto(updater=None) | |||
There was a problem hiding this comment.
nit: you don't need updater=None since you added the default
There was a problem hiding this comment.
Yea, this was a relic from my debugging. Good catch.
woop
added a commit
that referenced
this pull request
Apr 21, 2021
#1488) * Fix no-op for GCS registry Signed-off-by: Willem Pienaar <[email protected]> * Unify signature Signed-off-by: Willem Pienaar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Willem Pienaar [email protected]
What this PR does / why we need it:
We introduced a bug with #1477. We allow initialization of the registry during
apply, even with empty repositories. However, support was only added for the local registry, not the GCS registry.Does this PR introduce a user-facing change?: