Fix created timestamp related errors for BigQuery source #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Klegar <[email protected]>
|
/kind housekeeping |
woop
reviewed
Apr 19, 2021
| @@ -281,7 +296,12 @@ def test_historical_features_from_parquet_sources(): | |||
| @pytest.mark.parametrize( | |||
| "provider_type", ["local", "gcp"], | |||
| ) | |||
| def test_historical_features_from_bigquery_sources(provider_type): | |||
| @pytest.mark.parametrize( | |||
| "created_timestamp_column", ["created", ""], | |||
There was a problem hiding this comment.
My only feedback is that these tests tend to run long, and will run even longer in the future the more we start to parameterize it. Would it be better to just have a single source (out of multiple) that doesnt have a created TS?
woop
reviewed
Apr 19, 2021
Signed-off-by: Jacob Klegar <[email protected]>
|
/lgtm |
woop
approved these changes
Apr 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Klegar [email protected]
What this PR does / why we need it: Fix errors in historical retrieval when created_timestamp_column is not set on a BigQuery data source
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: