-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary MAVEN_CONFIG #1472
Conversation
Hi @danielsiwiec. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Dan Siwiec <[email protected]>
a7a2bd8
to
2e384ab
Compare
/assign @woop |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielsiwiec, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
Remove unused environment variable. The
MAVEN_CONFIG
variable is used by the maven Docker image (which we're not using) and is not used by Maven itself in any way. It is colliding with Maven Wrapper configuration (which also uses this variable) and is causing feast-dev/feast-java-old#26 to fail