Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI entities command & add feature-views command #1471

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Apr 15, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it: Existing CLI entities command is trying to use feast core. Instead, it should be using new FeastStore abstraction. Also, the CLI didn't have a way of accessing feature views, and I'm adding that as well. Here are the 4 new commands:

feast entities list
feast entities describe <entity-name>
feast feature-views list
feast feature-views describe <feature-view-name>

I also noticed that in bunch of places where we want to throw errors, we use Exception class, which has some disadvantages. For example, when you want to catch this error you have to use except Exception as e, which can catch all different kinds of exceptions. In this PR I started a new errors.py class where I introduces some new exception types, so it's easier to catch them.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix CLI entities command & add feature-views command

@woop
Copy link
Member

woop commented Apr 15, 2021

In this PR I started a new errors.py class where I introduces some new exception types, so it's easier to catch them.

Nice!

@woop
Copy link
Member

woop commented Apr 15, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit ec265f9 into master Apr 15, 2021
@woop woop deleted the cli-entities-fvs branch May 12, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants