Fix CLI entities command & add feature-views command #1471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: Existing CLI entities command is trying to use feast core. Instead, it should be using new FeastStore abstraction. Also, the CLI didn't have a way of accessing feature views, and I'm adding that as well. Here are the 4 new commands:
I also noticed that in bunch of places where we want to throw errors, we use
Exception
class, which has some disadvantages. For example, when you want to catch this error you have to useexcept Exception as e
, which can catch all different kinds of exceptions. In this PR I started a newerrors.py
class where I introduces some new exception types, so it's easier to catch them.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: