Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix & clean up Feast CLI commands #1463

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Fix & clean up Feast CLI commands #1463

merged 1 commit into from
Apr 14, 2021

Conversation

tsotnet
Copy link
Collaborator

@tsotnet tsotnet commented Apr 13, 2021

Signed-off-by: Tsotne Tabidze [email protected]

What this PR does / why we need it:

  • Remove repo_path argument from commands: apply, registry-dump, teardown, materialize, materialize-incremental
  • Remove commands: config, feature-tables, projects
  • Misc
    • Add help text to init command
    • Provide only SDK version in version command
    • Add help text including links to doc & Feast Slack to feast command
    • Add feature views to registry-dump command

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix & clean up Feast CLI commands

@tsotnet tsotnet requested review from jklegar and woop as code owners April 13, 2021 22:35
woop
woop reviewed Apr 13, 2021
View reviewed changes
sdk/python/feast/cli.py Outdated
"""
Applies a feature repo
Apply a feature repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a more descriptive message here? Create or update a feature store deployment?

Copy link
Collaborator Author

@tsotnet tsotnet Apr 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. How about also changing teardown - Tear down infra for a feature repo to teardown - Tear down deployed feature store infrastructure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@tsotnet
Copy link
Collaborator Author

tsotnet commented Apr 13, 2021

/test

@feast-ci-bot
Copy link
Collaborator

@tsotnet: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test test-core-and-ingestion
  • /test test-serving
  • /test test-java-sdk
  • /test test-telemetry
  • /test test-golang-sdk

Use /test all to run the following jobs:

  • test-telemetry

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fix Feast CLI commands
a4e332f 
Signed-off-by: Tsotne Tabidze <[email protected]>
@woop
Copy link
Member

woop commented Apr 14, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsotnet, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 833abfa into master Apr 14, 2021
@woop woop deleted the fix-cli-commands branch May 12, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@jklegar jklegar Awaiting requested review from jklegar

Assignees

@woop woop

Labels
approved kind/housekeeping lgtm ok-to-test release-note size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsotnet @feast-ci-bot @woop