Fix timezone issue in materialize & materialize_incremental #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsotnet
force-pushed
the
fix-timezone-issue
branch
from
fed5c36 to
8939ab9
Compare
|
/ok-to-test |
tsotnet
force-pushed
the
fix-timezone-issue
branch
3 times, most recently
from
5ca0e94 to
415ee45
Compare
feast-ci-bot
added
size/L
release-note
and removed
size/M
do-not-merge/release-note-label-needed
labels
tsotnet
force-pushed
the
fix-timezone-issue
branch
from
415ee45 to
3e44b15
Compare
woop
reviewed
Apr 7, 2021
woop
requested changes
Apr 7, 2021
tsotnet
force-pushed
the
fix-timezone-issue
branch
2 times, most recently
from
38cf31a to
77c2e70
Compare
Signed-off-by: Tsotne Tabidze <[email protected]>
tsotnet
force-pushed
the
fix-timezone-issue
branch
from
77c2e70 to
293d973
Compare
woop
approved these changes
Apr 7, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsotnet, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: Fixes an issue of mixing tz-aware and tz-naive timestamps. This was happening in fs.materialize & fs.materialize_incremental (both call _materialize_single_feature_view where I applied the fix), in FeatureView where the time zones aren't persisted between to_proto & from_proto, and in LocalSqlite:pull_latest_from_table_or_query where the source dataframe could have some tz-naive timestamps.
I also refactored
test_materialize_from_bigquery_to_datastore.pyintotest_materialize.pywhere I maintain both existing test cases but also add a unit test that runs in the local mode. Lastly, I made sure to mix in tz-naive and tz-aware timestamps so that we make sure this bug is now well-tested.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: