Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI apply in local mode idempotent #1401

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

oavdeev
Copy link
Collaborator

@oavdeev oavdeev commented Mar 21, 2021

What this PR does / why we need it:
Make sure you can run apply twice and not get an error the second time.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@oavdeev
Copy link
Collaborator Author

oavdeev commented Mar 21, 2021

/kind bug

@oavdeev
Copy link
Collaborator Author

oavdeev commented Mar 21, 2021

/ok-to-test

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Mar 21, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 3ae52ff into feast-dev:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants