-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support make protos on Mac #1371
Conversation
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tedhtchang, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @tedhtchang. Would you mind signing the commit please? Have a look here: https://github.com/feast-dev/feast/pull/1371/checks?check_run_id=2054899330 |
Signed-off-by: ted chang <[email protected]>
31db4a2
to
c961503
Compare
Thanks @woop. I signed off.
while running |
/lgtm |
What this PR does / why we need it:
I got "/bin/sh: /Users/tedchang/bin/protoc: cannot execute binary file" error while running "make protos" on Mac.
Does this PR introduce a user-facing change?:
NONE