Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support make protos on Mac #1371

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

tedhtchang
Copy link
Contributor

What this PR does / why we need it:
I got "/bin/sh: /Users/tedchang/bin/protoc: cannot execute binary file" error while running "make protos" on Mac.

Does this PR introduce a user-facing change?:
NONE


@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Mar 8, 2021

Thanks @tedhtchang.

Would you mind signing the commit please? Have a look here: https://github.com/feast-dev/feast/pull/1371/checks?check_run_id=2054899330

@tedhtchang
Copy link
Contributor Author

tedhtchang commented Mar 8, 2021

Thanks @tedhtchang.

Would you mind signing the commit please? Have a look here: https://github.com/feast-dev/feast/pull/1371/checks?check_run_id=2054899330

Thanks @woop. I signed off.
I figure I don't need to run make protos on my Mac. Please discard this PR if it's not needed.
I ran make protos because I hit the error

[feast-java] COMPILATION ERROR: package feast.proto.core.FeatureTableProto does not exist

while running make build-java-no-tests but I found the solution you posted in the slack channel.

@woop
Copy link
Member

woop commented Mar 9, 2021

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants