Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for k8s-spark resource template #1363

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Improve documentation for k8s-spark resource template #1363

merged 1 commit into from
Mar 6, 2021

Conversation

theofpa
Copy link
Contributor

@theofpa theofpa commented Mar 2, 2021

What this PR does / why we need it:
Documents the SPARK_K8S_JOB_TEMPLATE_PATH constant with example and reference to the spec.

@feast-ci-bot
Copy link
Collaborator

@theofpa: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

Hi @theofpa. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: theofpa, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Mar 2, 2021

Thanks @theofpa this is great!

Please remember to sign the commit!

@woop woop changed the title improve doc for k8s-spark resource template Improve documentation for k8s-spark resource template Mar 3, 2021
@woop woop merged commit 1e0ca5a into feast-dev:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants