Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs page for Azure setup #1276

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Add docs page for Azure setup #1276

merged 2 commits into from
Jan 27, 2021

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Jan 20, 2021

What this PR does / why we need it: adds a docs page for Azure setup

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@jklegar
add azure setup docs page
aff22be 
Signed-off-by: Jacob Klegar <[email protected]>
@jklegar
small fixes
b73c62c 
Signed-off-by: Jacob Klegar <[email protected]>
@feast-ci-bot
Copy link
Collaborator

@jklegar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-sparkop b73c62c link /test test-end-to-end-sparkop
test-end-to-end-aws b73c62c link /test test-end-to-end-aws
test-end-to-end-azure b73c62c link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jklegar
Copy link
Collaborator Author

jklegar commented Jan 20, 2021

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Jan 20, 2021
woop
woop reviewed Jan 26, 2021
View reviewed changes
docs/getting-started/install-feast/README.md

### Google Cloud GKE \(with Terraform\)

This guide installs Feast into a Google Cloud environment using Terraform. The Terraform script is opinionated and intended to allow you to start quickly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here? It's GKE?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it should've been added to this page before so I just added it in as part of this diff

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jan 27, 2021

/lgtm

@jklegar jklegar merged commit 2cc2f3d into feast-dev:master Jan 27, 2021
@jklegar jklegar deleted the jacob_docs_azure branch February 4, 2021 23:57
@jklegar jklegar mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@khorshuheng khorshuheng Awaiting requested review from khorshuheng

@pyalex pyalex Awaiting requested review from pyalex

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels
approved kind/feature New feature or request lgtm release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jklegar @feast-ci-bot @woop