Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix azure blob storage access in e2e tests #1253

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Jan 6, 2021

Signed-off-by: Jacob Klegar [email protected]

What this PR does / why we need it: fix failing azure e2e test

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Jacob Klegar <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jklegar
To complete the pull request process, please assign pyalex after the PR has been reviewed.
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jacob Klegar <[email protected]>
Signed-off-by: Jacob Klegar <[email protected]>
@feast-ci-bot
Copy link
Collaborator

@jklegar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure 1776fc1 link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jklegar jklegar merged commit 7226bde into feast-dev:master Jan 6, 2021
@feast-ci-bot
Copy link
Collaborator

@jklegar: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file .prow/config.yaml

In response to this:

Signed-off-by: Jacob Klegar [email protected]

What this PR does / why we need it: fix failing azure e2e test

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jklegar jklegar deleted the jacob_fix_tests branch February 4, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants