remove stage_dataframe from the launcher interface #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Avdeev <[email protected]>
oavdeev
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
|
/kind housekeeping |
woop
reviewed
Dec 9, 2020
| def stage_dataframe(df, event_timestamp_column: str, client: "Client") -> FileSource: | ||
| launcher = resolve_launcher(client._config) | ||
| return launcher.stage_dataframe(df, event_timestamp_column) | ||
| def stage_dataframe(df, event_timestamp_column: str, config: Config) -> FileSource: |
There was a problem hiding this comment.
Can we add a basic description/comment?
Signed-off-by: Oleg Avdeev <[email protected]>
woop
approved these changes
Dec 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oavdeev, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It was only implemented for EMR anyway. Also now that all upload paths are using the staging client, we can implement this once without having launcher-specific implementations.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: