Features are not being ingested due to max age overflow #1209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Moskalenko [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
With big values of max age (like 1 month) stored as Integer (2628000) converting to milliseconds that happens during writing to redis fails with overflow
2628000 * 1000 = -1666967296
. Thus all rows are being stored with negative expiry time and being deleted right away.This PR suggests use Long instead of Int for max age. Alternative would be to do
maxAge.toLong
before converting to milliseconds, but it's very easy to miss that part.Does this PR introduce a user-facing change?: