Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features are not being ingested due to max age overflow #1209

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Dec 2, 2020

Signed-off-by: Oleksii Moskalenko [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

With big values of max age (like 1 month) stored as Integer (2628000) converting to milliseconds that happens during writing to redis fails with overflow 2628000 * 1000 = -1666967296. Thus all rows are being stored with negative expiry time and being deleted right away.

This PR suggests use Long instead of Int for max age. Alternative would be to do maxAge.toLong before converting to milliseconds, but it's very easy to miss that part.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Oleksii Moskalenko <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Dec 2, 2020

@pyalex you can just type NONE into the release note box if you want release-note-none label to be added.

@pyalex
Copy link
Collaborator Author

pyalex commented Dec 2, 2020

@woop sure, I was not aware of this option

@feast-ci-bot
Copy link
Collaborator

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-aws 5cf1fcd link /test test-end-to-end-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex pyalex merged commit ad67392 into feast-dev:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants