Lazy metrics initialization (to correct pick up in executor) #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
khorshuheng
approved these changes
Nov 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksii Moskalenko <[email protected]>
pyalex
force-pushed
the
ingestion-metrics-improv
branch
from
2b35c92 to
2cdad38
Compare
|
/lgtm |
pyalex
added a commit
that referenced
this pull request
Nov 24, 2020
Signed-off-by: Oleksii Moskalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Moskalenko [email protected]
What this PR does / why we need it:
RedisSinkMetricSourcecannot be initialized withMetricsSystemin executor, sinceSparkEnvis not yet available at the moment ofMetricsSystem.start. To resolve it I movedRedisSinkMetricSourceregistering insideRedisSinkRelation.I also replaced
Librato-stylestatsd format withDogStatsDextension, since it seems to be more stable (and it was previously used in ingestion job with Beam).Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: