Add serving integration test for updated feature type #1112
Conversation
| coreClient, projectName, featureTableName, entities, features, 7200); | ||
|
|
||
| // Sleep is necessary to ensure caching (every 10s) of updated FeatureTable is done | ||
| try { |
There was a problem hiding this comment.
is it possible to manually trigger cache invalidation?
or at least configure it to every second for example?
There was a problem hiding this comment.
Unfortunately, we set the number of seconds here, I don't think it's possible to configure this setting.
There was a problem hiding this comment.
but it can be moved to Spring config, right?
There was a problem hiding this comment.
You mean make it configurable thru serving's application.yml?
Signed-off-by: Terence <[email protected]>
terryyylim
force-pushed
the
update-serving-integration-test
branch
from
adf8fde
to
6f9cbd6
Compare
Signed-off-by: Terence <[email protected]>
terryyylim
force-pushed
the
update-serving-integration-test
branch
from
6f9cbd6
to
a653fea
Compare
|
|
||
| @Autowired | ||
| public SpecServiceConfig(FeastProperties feastProperties) { | ||
| feastCoreHost = feastProperties.getCoreHost(); | ||
| feastCorePort = feastProperties.getCoreGrpcPort(); | ||
| CACHE_REFRESH_RATE_SECONDS = feastProperties.getCoreCacheRefreshInterval(); |
There was a problem hiding this comment.
- since it's not a constant anymore shouldn't it be lowercased?
- add
this.please
Signed-off-by: Terence <[email protected]>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
Signed-off-by: Terence [email protected]
What this PR does / why we need it:
Following this PR, this PR adds an integration test that checks for
NOT FOUNDvalues in online retrieval when feature types are changed.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: