Add gh workflow for dockerhub #1098
Conversation
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
.github/workflows/release.yml
Outdated
| with: | ||
| version: '290.0.1' | ||
| export_default_credentials: true | ||
| - run: gcloud auth configure-docker --quiet |
There was a problem hiding this comment.
If I'm understanding it correctly, it configures the credentials for the github action since we're not providing the SA key explicitly in the previous step as shown in the example here.
There was a problem hiding this comment.
@terryyylim gcloud auth configure-docker is only used when you need to authenticate docker to push to Google container registry.
|
/retest |
terryyylim
changed the title
terryyylim
force-pushed
the
add-dockerhub-action
branch
from
31e8d09 to
0f3f935
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test test-end-to-end-gcp |
|
/retest |
|
/lgtm |
|
/test test-end-to-end |
Signed-off-by: Terence <[email protected]>
Signed-off-by: Terence <[email protected]>
Signed-off-by: Terence <[email protected]>
terryyylim
force-pushed
the
add-dockerhub-action
branch
from
0f3f935 to
00ee61d
Compare
|
/test test-end-to-end |
|
/lgtm |
Signed-off-by: Terence [email protected]
What this PR does / why we need it:
This PR adds a github workflow to build and push to Dockerhub for every new release.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: