Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Python SDK to remove v1 concepts #1023

Merged
merged 34 commits into from
Oct 8, 2020
Merged

Refactor Python SDK to remove v1 concepts #1023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
aad0a47
Cleanup cli
terryyylim Oct 2, 2020
53d40cf
Cleanup Python SDK
terryyylim Oct 5, 2020
6ed731c
Cleanup python unit tests
terryyylim Oct 5, 2020
306ec08
Refactor and parallelize e2e redis tests
terryyylim Oct 5, 2020
86f27e3
Remove e2e bq tests
terryyylim Oct 5, 2020
0205ea8
Fix env variable
terryyylim Oct 5, 2020
894ee48
Fix pytest redis
terryyylim Oct 5, 2020
f9a9a32
Revert "Remove e2e bq tests"
terryyylim Oct 5, 2020
7e9ad2b
Fix pytest redis
terryyylim Oct 5, 2020
f7c5e31
Remove unused batch tests
terryyylim Oct 5, 2020
28830de
Fix docker-compose test
terryyylim Oct 5, 2020
d1c4346
Address PR comments
terryyylim Oct 5, 2020
c917762
Remove src folder for e2e tests
terryyylim Oct 5, 2020
e4af101
Address PR comments
terryyylim Oct 5, 2020
69bda02
Expose Source instead of Options native class
terryyylim Oct 5, 2020
7f794c3
Refactor e2e tests without specification
terryyylim Oct 5, 2020
a3d5d94
Fix data partitioning for ingest method
terryyylim Oct 6, 2020
6ce6e41
Cleanup date partition logic and add ingest test
terryyylim Oct 6, 2020
4ec077c
Remove type field from datasource classes
terryyylim Oct 6, 2020
e6cb88f
Remove not so useful test
terryyylim Oct 6, 2020
f09c65e
Address PR comments
terryyylim Oct 6, 2020
ab47c40
Cleanup the way protos are converted
terryyylim Oct 7, 2020
40c3e29
Split ingest function and add more tests
terryyylim Oct 7, 2020
c9506c3
Cleanup FeatureTable and DataSource
terryyylim Oct 7, 2020
f1fa274
Some fixes
terryyylim Oct 7, 2020
d43bb44
Add BQ source test
terryyylim Oct 7, 2020
33bd9db
Revert "Add BQ source test"
terryyylim Oct 7, 2020
99821c5
Add BQ source test
terryyylim Oct 7, 2020
5367a48
Update perms for bq test
terryyylim Oct 7, 2020
d8ade37
Revert "Update perms for bq test"
terryyylim Oct 7, 2020
20cd4d9
Cleanup datasource
terryyylim Oct 8, 2020
404cc36
Renaming and optimize file search loop
terryyylim Oct 8, 2020
6990f16
Remove duplicated code in pytest
terryyylim Oct 8, 2020
b6ee24b
Fix prow config
terryyylim Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ lint-python:
cd ${ROOT_DIR}/sdk/python; flake8 feast/ tests/
cd ${ROOT_DIR}/sdk/python; black --check feast tests

cd ${ROOT_DIR}/tests/e2e; mypy redis/
cd ${ROOT_DIR}/tests/e2e; mypy .
cd ${ROOT_DIR}/tests/e2e; isort . --check-only
cd ${ROOT_DIR}/tests/e2e; flake8 .
cd ${ROOT_DIR}/tests/e2e; black --check .
Expand Down
2 changes: 1 addition & 1 deletion infra/scripts/test-docker-compose.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ export FEAST_ONLINE_SERVING_CONTAINER_IP_ADDRESS=$(docker inspect -f '{{range .N
${PROJECT_ROOT_DIR}/infra/scripts/wait-for-it.sh ${FEAST_ONLINE_SERVING_CONTAINER_IP_ADDRESS}:6566 --timeout=120

# Run e2e tests for Redis
docker exec feast_jupyter_1 bash -c 'cd /feast/tests/e2e/redis && pytest --verbose -rs basic-ingest-redis-serving.py --core_url core:6565 --serving_url=online_serving:6566 --jobcontroller_url=jobcontroller:6570 --kafka_brokers=kafka:9092'
docker exec feast_jupyter_1 bash -c 'cd /feast/tests/e2e && pytest *.py --core_url core:6565 --serving_url=online_serving:6566 --kafka_brokers=kafka:9092'
307 changes: 0 additions & 307 deletions infra/scripts/test-end-to-end-batch-dataflow.sh
View file
Open in desktop

This file was deleted.

Loading