Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project name is having missing validation to llimit the size #4626

Closed
lokeshrangineni opened this issue Oct 14, 2024 · 1 comment
Closed

Project name is having missing validation to llimit the size #4626

lokeshrangineni opened this issue Oct 14, 2024 · 1 comment
Labels
kind/bug priority/p2

Comments

@lokeshrangineni
Copy link
Contributor

lokeshrangineni commented Oct 14, 2024 •
edited
Loading

Expected Behavior

Based on the documentation project name should be limited to 16 chars along with other validations only to allow alpha numeric characters and allow _ but not as a beginning character.

Ask is - We have to update the documentation to reflect the current behavior of the product.

Current Behavior

Current behavior does not limit the project length. Allows unlimited chars.

Steps to reproduce

  • do the feast init to create a new feast repo with default configurations.
  • go to feature_repo folder after the repo creation.
  • modify the feature_store.yaml file and update the project name to more than 16 chars.
  • execute feast apply command.
lokeshrangineni added a commit to lokeshrangineni/feast that referenced this issue Oct 14, 2024
@lokeshrangineni
Added the fix to add missing project length validation.
85f8895 
 Addressing the issue - feast-dev#4626
@lokeshrangineni lokeshrangineni mentioned this issue Oct 14, 2024
Merged
lokeshrangineni added a commit to lokeshrangineni/feast that referenced this issue Oct 14, 2024
@lokeshrangineni
Added the fix to add missing project length validation.
1641c43 
 Addressing the issue - feast-dev#4626

Signed-off-by: lrangine <[email protected]>
lokeshrangineni added a commit to lokeshrangineni/feast that referenced this issue Oct 14, 2024
@lokeshrangineni
Added the fix to add missing project length validation.
3d3a2cd 
 Addressing the issue - feast-dev#4626

Signed-off-by: lrangine <[email protected]>
Signed-off-by: lrangine <[email protected]>

Added the fix to add missing project length validation.
 Addressing the issue - feast-dev#4626

Signed-off-by: lrangine <[email protected]>
lokeshrangineni added a commit to lokeshrangineni/feast that referenced this issue Oct 14, 2024
@lokeshrangineni
Updated the documentation to make it clear after spending some time.
235fd43 
 Addressing the issue - feast-dev#4626

Signed-off-by: lrangine <[email protected]>
lokeshrangineni added a commit to lokeshrangineni/feast that referenced this issue Oct 14, 2024
@lokeshrangineni
Updated the documentation to make it clear after spending some time.
ca8ce3a 
 Addressing the issue - feast-dev#4626

Signed-off-by: lrangine <[email protected]>
franciscojavierarceo pushed a commit that referenced this issue Oct 14, 2024
@lokeshrangineni
fix: Updating the documentation and adding tests for project length (#…
945b0fa 
…4628)

Updated the documentation to make it clear after spending some time.
 Addressing the issue - #4626

Signed-off-by: lrangine <[email protected]>
robhowley pushed a commit to robhowley/feast that referenced this issue Oct 16, 2024
@lokeshrangineni @robhowley
fix: Updating the documentation and adding tests for project length (f…
3976b7e 
…east-dev#4628)

Updated the documentation to make it clear after spending some time.
 Addressing the issue - feast-dev#4626

Signed-off-by: lrangine <[email protected]>
@lokeshrangineni
Copy link
Contributor Author

Created the PR to address the issue - #4628
We can close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lokeshrangineni