Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Make v0.3.7 release, publish artifacts for v0.3.6 also #442

Closed
ches opened this issue Jan 26, 2020 · 10 comments
Closed

[chore] Make v0.3.7 release, publish artifacts for v0.3.6 also #442

ches opened this issue Jan 26, 2020 · 10 comments

Comments

@ches
Copy link
Member

ches commented Jan 26, 2020

v0.3.6 has been tagged, but artifacts are not on Maven Central.

I believe the only changes since 0.3.6 are #360 and #426/#407, but a new release would be helpful for us, we need the datatypes-java module published.

@woop
Copy link
Member

woop commented Jan 26, 2020

v0.3.6 has been tagged, but artifacts are not on Maven Central.

Is this due to the release automation landing after 0.3.6, or is something wrong?

I believe the only changes since 0.3.6 are #360 and #426/#407, but a new release would be helpful for us, we need the datatypes-java module published.

Makes sense. We can pick that up early this week.

@ches
Copy link
Member Author

ches commented Jan 27, 2020

Is this due to the release automation landing after 0.3.6, or is something wrong?

Yes, I believe it's because the release automation came to the v0.3 series branch after 0.3.6.

Although, @davidheryanto I see the Prow config has the filter to match branches/tags that look like a version—will it trigger when a tag object is pushed, or does there need to be a PR? It looks like we try to set REVISION from pull request base, is that going to work as desired?

@ches
Copy link
Member Author

ches commented Jan 27, 2020

Note: probably also from timing of when things landed, HEAD of v0.3-branch has <revision>0.3.6-SNAPSHOT</revision> in the POM, it should be 0.3.7-SNAPSHOT now since we're past 0.3.6 final. We can fix this in the course of this ticket.

@davidheryanto
Copy link
Collaborator

davidheryanto commented Jan 29, 2020

Hi @ches yes the pushing of artifacts will be triggered whenever a new branch or tag (with a name that match the semantic versioning regex) is pushed.

It does not require a pull request, but I think it's good to do so (in case of v0.3.7, we should probably make a pull request to backport some commits to v0.3-branch), because currently the end to end test will only run on pull request (I currently make an assumption that whenever a new tag or branch is pushed on the main Feast repository, it has passed the end to end test, so the artifacts publishing step will skip it).

Will pick up some time this week the publishing of Artifacts for Feast v0.3.7 and v0.3.6

@ches
Copy link
Member Author

ches commented Jan 29, 2020

in case of v0.3.7, we should probably make a pull request to backport some commits to v0.3-branch

Are there some that you have in mind?

I created an in issue label yesterday called backport-candidate, we may be one of the primary stakeholders interested in backports to v0.3 at this point but it'd be great if all maintainers could pitch in to applying it to PRs that seem appropriate. My thinking was to be able to filter closed issues to review these, as it's a challenge for us to keep up with every change that's coming through to catch bug fixes, etc. that might be important.

@ches
Copy link
Member Author

ches commented Jan 29, 2020

Thanks for the answers about the automation by the way!

ches added a commit that referenced this issue Feb 13, 2020
v0.3.6 was tagged and 0.3.x development has moved forward. See #442
@ches
Copy link
Member Author

ches commented Mar 27, 2020

Okay, it's come time that I need to ask for help for completing either this one or #476—I'm not certain if I have complete information to do this self-service and with the access rights I have.

@woop @davidheryanto @zhilingc @khorshuheng

@woop
Copy link
Member

woop commented Mar 28, 2020

I definitely want both #442 and #472 to be completed successfully.

I'm trying to figure out what all the missing pieces are here. @ches is it possible for you to enumerate your uncertainties? Or if you have certainties (like access you need) then you could also let me know and I will try to address them.

Are there some that you have in mind?

@davidheryanto would love to get your response here.

@davidheryanto
Copy link
Collaborator

davidheryanto commented Mar 28, 2020

Hi @ches sorry for the slow reponse.
Feast Java SDK v0.3.6 is not published to Maven central because when it was tagged, the CI jobs for v0.3-branch do not have publish-java-sdk step yet.

I will manually publish Java SDK for v0.3.6 today.
Java SDK for v0.3.6 is released but it will take a few days to appear in Maven central.

v0.3.6 has not introduced datatypes-java module, so there will be no release for datatypes-java in v0.3.6

For subsequent releases in v0.3, the CI has already configured publish-java-sdk job so the Java SDK will be available in Maven central.

Do we want to release v0.3.7 based on the current state of v0.3-branch?

@ches ches mentioned this issue May 1, 2020
@ches
Copy link
Member Author

ches commented May 4, 2020

Closed by #670.

Modules like feast-sdk for Java were published for v0.3.6 by @davidheryanto back in March as noted in the previous comment here, those for v0.3.7 including datatypes-java which was newly added in this release are on Maven Central now.

Thanks everyone!

@ches ches closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants