fix: Add `X-Trino-Extra-Credential` header and remove user override #3246

ammarar · 2022-09-23T18:04:53Z

What this PR does / why we need it: Adds more authentication properties to users of Trino

Which issue(s) this PR fixes:

Fixes #

felixwang9817 · 2022-09-24T00:01:49Z

hey @ammarar thanks for your PR! your changes look good to me - I'm happy to stamp once you sign your commit and format your PR title correctly (it should be something like fix: PR Title, you can see other PRs for examples)

codecov-commenter · 2022-09-24T00:10:10Z

Codecov Report

Base: 67.50% // Head: 76.64% // Increases project coverage by +9.14% 🎉

Coverage data is based on head (dae2b2f) compared to base (b48d36b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3246      +/-   ##
==========================================
+ Coverage   67.50%   76.64%   +9.14%     
==========================================
  Files         179      216      +37     
  Lines       16371    18198    +1827     
==========================================
+ Hits        11051    13948    +2897     
+ Misses       5320     4250    -1070

Flag	Coverage Δ
integrationtests	`67.30% <ø> (-0.20%)`	⬇️
unittests	`58.14% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tores/contrib/trino_offline_store/trino_queries.py	`14.58% <0.00%> (ø)`
...stores/contrib/trino_offline_store/trino_source.py	`5.37% <ø> (ø)`
...on/feast/infra/materialization/snowflake_engine.py	`93.18% <0.00%> (-0.41%)`	⬇️
...tion/contrib/spark/spark_materialization_engine.py	`71.84% <0.00%> (-0.28%)`	⬇️
...offline_stores/contrib/spark_repo_configuration.py	`100.00% <0.00%> (ø)`
...ores/contrib/trino_offline_store/tests/__init__.py	`100.00% <0.00%> (ø)`
...tion/feature_repos/universal/online_store/hbase.py	`50.00% <0.00%> (ø)`
...thon/feast/infra/utils/postgres/postgres_config.py	`100.00% <0.00%> (ø)`
...s/contrib/mssql_offline_store/tests/data_source.py	`46.93% <0.00%> (ø)`
...ine_stores/contrib/cassandra_repo_configuration.py	`100.00% <0.00%> (ø)`
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: ammarar <[email protected]>

felixwang9817

/lgtm

feast-ci-bot · 2022-09-24T01:13:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammarar, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

felixwang9817 · 2022-09-24T01:13:31Z

thanks for fixing @ammarar, just stamped your PR!

Signed-off-by: ammarar <[email protected]>

felixwang9817 · 2022-09-24T02:23:10Z

/lgtm

…3246) * do changes with signing Signed-off-by: ammarar <[email protected]> * lint fix Signed-off-by: ammarar <[email protected]> Signed-off-by: ammarar <[email protected]>

…east-dev#3246) * do changes with signing Signed-off-by: ammarar <[email protected]> * lint fix Signed-off-by: ammarar <[email protected]> Signed-off-by: ammarar <[email protected]>

## [0.25.1](v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([f38506c](f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([a2cb995](a2cb995)) * Add stream feature view in the Web UI ([#3257](#3257)) ([47d4c93](47d4c93)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([fdc8d67](fdc8d67)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([8f2fb58](8f2fb58)) * Return 422 on bad push source name ([#3214](#3214)) ([8abbcd9](8abbcd9)) * Stream feature view not shown in the UI ([#3251](#3251)) ([55e28e2](55e28e2)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([e7ed3d5](e7ed3d5))

## [0.25.1](feast-dev/feast@v0.25.0...v0.25.1) (2022-09-30) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([f38506c](feast-dev@f38506c)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([a2cb995](feast-dev@a2cb995)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([47d4c93](feast-dev@47d4c93)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([fdc8d67](feast-dev@fdc8d67)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([8f2fb58](feast-dev@8f2fb58)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([8abbcd9](feast-dev@8abbcd9)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([55e28e2](feast-dev@55e28e2)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([e7ed3d5](feast-dev@e7ed3d5))

# [0.26.0](v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([#3246](#3246)) ([164e666](164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([#3261](#3261)) ([6f6cbb7](6f6cbb7)) * Add stream feature view in the Web UI ([#3257](#3257)) ([1f70b3a](1f70b3a)) * Build dockerfile correctly ([#3239](#3239)) ([a2dc0d0](a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([#3255](#3255)) ([97b7ab9](97b7ab9)) * Enable users to upgrade a batch source into a push source ([#3213](#3213)) ([1b312fb](1b312fb)) * Fix docker image for feature-server ([#3272](#3272)) ([eff01d1](eff01d1)) * Fix Feast UI release process to update the feast-ui package ([#3267](#3267)) ([a9d48d0](a9d48d0)) * Return 422 on bad push source name ([#3214](#3214)) ([b851e01](b851e01)) * Stream feature view meta undefined created_timestamp issue ([#3266](#3266)) ([12e1a8f](12e1a8f)) * Stream feature view not shown in the UI ([#3251](#3251)) ([e713dda](e713dda)) * Udf in stream feature view UI shows pickled data ([#3268](#3268)) ([0728117](0728117)) * Update snowflake materialization messages ([#3230](#3230)) ([a63d440](a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([#3271](#3271)) ([b9b9c54](b9b9c54)) * Use configured user in env var instead of "user" for Trino ([#3254](#3254)) ([532d8a1](532d8a1)) ### Features * Add mysql as online store ([#3190](#3190)) ([cb8db84](cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([#3231](#3231)) ([95fdb19](95fdb19)) * Add request_timeout setting for cassandra online store adapter ([#3256](#3256)) ([da20757](da20757)) * Add tag description in Field in the Feast UI ([#3258](#3258)) ([086f279](086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([#3253](#3253)) ([f80f05f](f80f05f)) * BigTable online store ([#3140](#3140)) ([6bc91c2](6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [#3174](#3174) ([#3203](#3203)) ([b48d36b](b48d36b))

# [0.26.0](feast-dev/feast@v0.25.0...v0.26.0) (2022-10-06) ### Bug Fixes * Add `X-Trino-Extra-Credential` header and remove user override ([feast-dev#3246](feast-dev#3246)) ([164e666](feast-dev@164e666)) * Add postgres to the feature server Dockerfile to fix helm chart flow ([feast-dev#3261](feast-dev#3261)) ([6f6cbb7](feast-dev@6f6cbb7)) * Add stream feature view in the Web UI ([feast-dev#3257](feast-dev#3257)) ([1f70b3a](feast-dev@1f70b3a)) * Build dockerfile correctly ([feast-dev#3239](feast-dev#3239)) ([a2dc0d0](feast-dev@a2dc0d0)) * Configuration to stop coercion of tz for entity_df ([feast-dev#3255](feast-dev#3255)) ([97b7ab9](feast-dev@97b7ab9)) * Enable users to upgrade a batch source into a push source ([feast-dev#3213](feast-dev#3213)) ([1b312fb](feast-dev@1b312fb)) * Fix docker image for feature-server ([feast-dev#3272](feast-dev#3272)) ([eff01d1](feast-dev@eff01d1)) * Fix Feast UI release process to update the feast-ui package ([feast-dev#3267](feast-dev#3267)) ([a9d48d0](feast-dev@a9d48d0)) * Return 422 on bad push source name ([feast-dev#3214](feast-dev#3214)) ([b851e01](feast-dev@b851e01)) * Stream feature view meta undefined created_timestamp issue ([feast-dev#3266](feast-dev#3266)) ([12e1a8f](feast-dev@12e1a8f)) * Stream feature view not shown in the UI ([feast-dev#3251](feast-dev#3251)) ([e713dda](feast-dev@e713dda)) * Udf in stream feature view UI shows pickled data ([feast-dev#3268](feast-dev#3268)) ([0728117](feast-dev@0728117)) * Update snowflake materialization messages ([feast-dev#3230](feast-dev#3230)) ([a63d440](feast-dev@a63d440)) * Updated quickstart notebook to patch an incorrect reference to an outdated featureview name ([feast-dev#3271](feast-dev#3271)) ([b9b9c54](feast-dev@b9b9c54)) * Use configured user in env var instead of "user" for Trino ([feast-dev#3254](feast-dev#3254)) ([532d8a1](feast-dev@532d8a1)) ### Features * Add mysql as online store ([feast-dev#3190](feast-dev#3190)) ([cb8db84](feast-dev@cb8db84)) * Add possibility to define feature_store.yaml path with env variable ([feast-dev#3231](feast-dev#3231)) ([95fdb19](feast-dev@95fdb19)) * Add request_timeout setting for cassandra online store adapter ([feast-dev#3256](feast-dev#3256)) ([da20757](feast-dev@da20757)) * Add tag description in Field in the Feast UI ([feast-dev#3258](feast-dev#3258)) ([086f279](feast-dev@086f279)) * Adding billing_project_id in BigQueryOfflineStoreConfig ([feast-dev#3253](feast-dev#3253)) ([f80f05f](feast-dev@f80f05f)) * BigTable online store ([feast-dev#3140](feast-dev#3140)) ([6bc91c2](feast-dev@6bc91c2)), closes [/github.com/spulec/moto/blob/master/CHANGELOG.md#400](https://github.com//github.com/spulec/moto/blob/master/CHANGELOG.md/issues/400) * Filter subset features in postgres [feast-dev#3174](feast-dev#3174) ([feast-dev#3203](feast-dev#3203)) ([b48d36b](feast-dev@b48d36b))

feast-ci-bot added the size/XS label Sep 23, 2022

felixwang9817 self-assigned this Sep 24, 2022

ammarar changed the title ~~add extra creds and remove user override~~ Fix: Add X-Trino-Extra-Credential header and remove user override Sep 24, 2022

do changes with signing

3293c85

Signed-off-by: ammarar <[email protected]>

ammarar force-pushed the trino-extra-props branch from ba446cb to 3293c85 Compare September 24, 2022 01:10

felixwang9817 changed the title ~~Fix: Add X-Trino-Extra-Credential header and remove user override~~ fix: Add X-Trino-Extra-Credential header and remove user override Sep 24, 2022

felixwang9817 approved these changes Sep 24, 2022

View reviewed changes

feast-ci-bot added the lgtm label Sep 24, 2022

feast-ci-bot added the approved label Sep 24, 2022

lint fix

dae2b2f

Signed-off-by: ammarar <[email protected]>

feast-ci-bot added size/S and removed lgtm size/XS labels Sep 24, 2022

feast-ci-bot added the lgtm label Sep 24, 2022

feast-ci-bot merged commit 164e666 into feast-dev:master Sep 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add `X-Trino-Extra-Credential` header and remove user override #3246

fix: Add `X-Trino-Extra-Credential` header and remove user override #3246

ammarar commented Sep 23, 2022

felixwang9817 commented Sep 24, 2022 •

edited

Loading

codecov-commenter commented Sep 24, 2022 •

edited

Loading

felixwang9817 left a comment

feast-ci-bot commented Sep 24, 2022

felixwang9817 commented Sep 24, 2022

felixwang9817 commented Sep 24, 2022

fix: Add X-Trino-Extra-Credential header and remove user override #3246

fix: Add X-Trino-Extra-Credential header and remove user override #3246

Conversation

ammarar commented Sep 23, 2022

felixwang9817 commented Sep 24, 2022 • edited Loading

codecov-commenter commented Sep 24, 2022 • edited Loading

Codecov Report

felixwang9817 left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Sep 24, 2022

felixwang9817 commented Sep 24, 2022

felixwang9817 commented Sep 24, 2022

fix: Add `X-Trino-Extra-Credential` header and remove user override #3246

fix: Add `X-Trino-Extra-Credential` header and remove user override #3246

felixwang9817 commented Sep 24, 2022 •

edited

Loading

codecov-commenter commented Sep 24, 2022 •

edited

Loading